This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix popover message positioning#7289
Merged
JeffryBooher merged 1 commit intomasterfrom Mar 24, 2014
Merged
Conversation
Contributor
|
Looks good. Ran unit/extension and integration tests = no failures. Performed scenario tests to check chevron and bubble placement at axis'. Merging |
JeffryBooher
added a commit
that referenced
this pull request
Mar 24, 2014
Fix popover message positioning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #7272 and #7278.
Interesting that it was the misplaced triangle that was causing the problem.
Also, test windows are now much wider, so the scroll test was failing.